Skip to content

Fix unexpected update in juiceruntime#4876

Merged
fluid-e2e-bot[bot] merged 1 commit intofluid-cloudnative:masterfrom
Syspretor:fix/unexpected-update-in-juice-fuse-update
May 20, 2025
Merged

Fix unexpected update in juiceruntime#4876
fluid-e2e-bot[bot] merged 1 commit intofluid-cloudnative:masterfrom
Syspretor:fix/unexpected-update-in-juice-fuse-update

Conversation

@Syspretor
Copy link
Copy Markdown
Collaborator

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@Syspretor Syspretor marked this pull request as draft May 8, 2025 07:53
Comment thread pkg/ddc/juicefs/sync_runtime.go Outdated
@cheyang
Copy link
Copy Markdown
Collaborator

cheyang commented May 11, 2025

I think we need to update the ConfigMap at the end of the syncFuseSpec function to persist the changes. This ensures that any modifications made during the synchronization process are saved and can be referenced in future operations.

@Syspretor Syspretor force-pushed the fix/unexpected-update-in-juice-fuse-update branch 5 times, most recently from 5328cab to 9f9fbd3 Compare May 16, 2025 03:48
@Syspretor Syspretor marked this pull request as ready for review May 16, 2025 05:58
@Syspretor Syspretor force-pushed the fix/unexpected-update-in-juice-fuse-update branch from 9f9fbd3 to 73f60bf Compare May 16, 2025 06:03
Comment thread pkg/ddc/juicefs/utils.go Outdated
@Syspretor Syspretor force-pushed the fix/unexpected-update-in-juice-fuse-update branch 2 times, most recently from c9818d1 to 8777924 Compare May 20, 2025 08:44
Signed-off-by: 玖宇 <guotongyu.gty@alibaba-inc.com>
@Syspretor Syspretor force-pushed the fix/unexpected-update-in-juice-fuse-update branch from 8777924 to fd25728 Compare May 20, 2025 08:48
@sonarqubecloud
Copy link
Copy Markdown

@Syspretor Syspretor requested a review from cheyang May 20, 2025 09:19
Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented May 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot Bot merged commit 0930bc8 into fluid-cloudnative:master May 20, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants